Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: Mangement of per-table limit by kudu cli ...................................................................... Patch Set 7: (4 comments) I did a quick first high-level pass. http://gerrit.cloudera.org:8080/#/c/17444/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17444/7//COMMIT_MSG@7 PS7, Line 7: Mangement management http://gerrit.cloudera.org:8080/#/c/17444/7//COMMIT_MSG@7 PS7, Line 7: cli CLI http://gerrit.cloudera.org:8080/#/c/17444/7//COMMIT_MSG@9 PS7, Line 9: cli CLI http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc@1210 PS7, Line 1210: unique_ptr<Action> change_table_limit = : ClusterActionBuilder("change_table_limit", &ChangeTableLimit) : .Description("Change the disk size limit or row count limit") : .AddRequiredParameter({ kTableNameArg, "Name of the table to change limit" }) : .AddOptionalParameter("disk_size_limit") : .AddOptionalParameter("row_count_limit") : .Build(); Instead of introducing those flags, how about adding a new 'set_limit' command with two separate sub-commands 'disk_size' and 'row_count' to set disk and row count limit correspondingly? That way there would be no need to introduce rather 'strange' special values (such as '-2') and would be much simpler to use, e.g.: kudu table set_limit disk_size <master_addresses> 12345678 kudu table set_limit row_count <master_addresses> 1000000 What do you think? -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 7 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 May 2021 05:00:51 +0000 Gerrit-HasComments: Yes
