Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: Mangement of per-table limit by kudu cli ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc@1210 PS7, Line 1210: unique_ptr<Action> change_table_limit = : ClusterActionBuilder("change_table_limit", &ChangeTableLimit) : .Description("Change the disk size limit or row count limit") : .AddRequiredParameter({ kTableNameArg, "Name of the table to change limit" }) : .AddOptionalParameter("disk_size_limit") : .AddOptionalParameter("row_count_limit") : .Build(); > I'm not sure there's an elegant way to disambiguate negative numbers from f BTW, what about using variadic arguments to read in the values? Also, it's possible to introduce 'unlimited' as a value instead of '-1', but then it will be necessary to do strtol or something (I guess that's not an issue). If variadic args trick doesn't work, I guess the alternatives suggested by Andrew are both viable choices. -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 7 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 19 May 2021 02:05:29 +0000 Gerrit-HasComments: Yes
