Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: Mangement of per-table limit by kudu cli ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc@1210 PS7, Line 1210: unique_ptr<Action> change_table_limit = : ClusterActionBuilder("change_table_limit", &ChangeTableLimit) : .Description("Change the disk size limit or row count limit") : .AddRequiredParameter({ kTableNameArg, "Name of the table to change limit" }) : .AddOptionalParameter("disk_size_limit") : .AddOptionalParameter("row_count_limit") : .Build(); > Instead of introducing those flags, how about adding a new 'set_limit' comm Good. It is a great idea to avoid using '-2'. Thanks for your suggestion. But I found a problem, if I want to specify -1 for the unlimited value, the kudu cli always take -1 as an invalid parameter, '-' is mistaken as positional argument. For example: $ bin/kudu table set_limit disk_size_limit localhost:7051 java_example-1620974445656_1 -1 ERROR: unknown command line flag '1' $ bin/kudu table set_limit disk_size_limit localhost:7051 java_example-1620974445656_1 "-1" ERROR: unknown command line flag '1' Is it possible to set "-1" as a valid positional parameter? -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 7 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 May 2021 10:46:21 +0000 Gerrit-HasComments: Yes
