Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17657 )

Change subject: [client] KUDU-2671 custom hash buckets API for table creation
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

I'll look into the test failure

http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc
File src/kudu/client/flex_partitioning_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc@272
PS5, Line 272:   //   key    0               1               2               3
> Nope, it's not possible to add a hash with only a single bucket.
SGTM



--
To view, visit http://gerrit.cloudera.org:8080/17657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4
Gerrit-Change-Number: 17657
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jul 2021 17:57:13 +0000
Gerrit-HasComments: Yes

Reply via email to