Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17657 )
Change subject: [client] KUDU-2671 custom hash buckets API for table creation ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/17657/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17657/6//COMMIT_MSG@10 PS6, Line 10: creating nit: to create http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.h@1261 PS6, Line 1261: bucketing. nit: bucket schema. http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.h@1264 PS6, Line 1264: scheme different from the scheme nit: schema instead of scheme http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.cc@953 PS6, Line 953: has_range_with_custom_hash_schema nit: can break early after this bool is set to true http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.cc@958 PS6, Line 958: simplitity nit: simplicity http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/client.cc@961 PS6, Line 961: splits nit: split rows Fwiw, would have to change the expected strings in the tests to match the new string if you do change this. http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/flex_partitioning_client-test.cc@200 PS6, Line 200: // One-level hash bucket structure with hashing on non-key column only: Aren't hash bucket schemas only permitted to be on any subset of primary key columns? Maybe I'm missing something here but how is this allowed? -- To view, visit http://gerrit.cloudera.org:8080/17657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4 Gerrit-Change-Number: 17657 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 15 Jul 2021 23:57:23 +0000 Gerrit-HasComments: Yes
