Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17657 )

Change subject: [client] KUDU-2671 custom hash buckets API for table creation
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/flex_partitioning_client-test.cc
File src/kudu/client/flex_partitioning_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/17657/6/src/kudu/client/flex_partitioning_client-test.cc@200
PS6, Line 200:     NO_FATALS(CheckTabletCount(kTableName, 3));
> Yeah, as you can see it's the table is created without any errors, and it e
+1 about the server-side check.

Wow, nice catch. I wonder if that's been there since day 1.



--
To view, visit http://gerrit.cloudera.org:8080/17657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4
Gerrit-Change-Number: 17657
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 20:37:15 +0000
Gerrit-HasComments: Yes

Reply via email to