Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/17674/8/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/8/src/kudu/integration-tests/alter_table-test.cc@2217 PS8, Line 2217: TEST_F(ReplicatedAlterTableTest, AlterReplicationFactor) { I'd like to see additional tests that write data to the table for the increase in replication factor case. On detecting fewer replicas master will initiate a tablet copy if the new tablet replica can't be caught up from WAL. So additionally I'd like to see a test that ensures the WAL has been GC'ed and tablet copy has successfully added new replica. See dynamic_multi_master-test for example. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 03 Aug 2021 20:38:42 +0000 Gerrit-HasComments: Yes
