Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h@1721 PS4, Line 1721: : /// Set the table's replication factor. : /// : /// @note The replication factor should be a odd number and range in : /// [1, --max_num_replicas] : /// : /// @param [in] replication_factor : /// The table's new replication factor. > How does the caller know that the change is in effect after Alter() returns This is an interesting question. Not only does the user need to wait for the alter to complete, but they may also want to wait for replication to fully complete, to fully realize the effects of the change. I wonder if it's worth introducing a means to wait for the table to finish recovering. Or mention in the comments that this doesn't wait for the table to replicate to full health. http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/integration-tests/alter_table-test.cc@2266 PS4, Line 2266: > It should be CHECK_OK() :) Typically in test code we prefer using ASSERT_OK so the test fails, rather than crashing the process. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 27 Jul 2021 21:02:16 +0000 Gerrit-HasComments: Yes
