Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG@14 PS4, Line 14: unit tests > It's good to wait all necessary replicas running and then Alter() return, b Yeah, I guess there is some work to be done to implement this a proper way. From the client's perspective, if not doing that, how does it know that the RF change is already in effect? http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h@1721 PS4, Line 1721: /// Set the table's replication factor. : /// : /// @note The replication factor should be a odd number and range in : /// [1, --max_num_replicas] : /// : /// @param [in] replication_factor : /// The table's new replication factor. : /// @return Raw pointer to this alterer object. How does the caller know that the change is in effect after Alter() returns Status::OK()? As I understand, the current semantics is that once KuduTableAlterer::Alter() returns Status::OK(), the changes become effective (like adding/dropping columns, etc.). Is that true for changing replication factor as well? If not, then how does a caller of the client API know that the change in RF has become effective? -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Sun, 25 Jul 2021 17:24:09 +0000 Gerrit-HasComments: Yes
