Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/client/client.h@1721 PS4, Line 1721: /// Set the table's replication factor. : /// : /// @note The replication factor should be a odd number and range in : /// [1, --max_num_replicas] : /// : /// @param [in] replication_factor : /// The table's new replication factor. : /// @return Raw pointer to this alterer object. > If altering a large table, it may cost a very long time until all tablets r Right -- in some aspects it's close to CreateTable() and DDL operations performed for ALTER TABLE, like creating many range partitions. A client might set higher timeout using KuduTableAlterer::timeout() method. As you can see, there is KuduTableAlterer::wait(bool) method, and by calling wait(false) those DDL operations start behaving like 'async' ones, just scheduling operations to be performed. It would be great to keep this API consistent and make sure SetReplicationFactor() works as other DDL operations in default operation mode (i.e. corresponding to calling KuduTableAlterer::wait(true)). Otherwise, a user of client API has no means to know when replication factor change becomes effective. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 30 Jul 2021 05:39:26 +0000 Gerrit-HasComments: Yes
