Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 7: Thanks for the patch. This is a very useful feature for many kudu users. In case of HMS integration, I see that we do not store the number of replicas in HMS atleast in the tables TABLE_PARAMS and TBLS. So nothing additional seems to be needed there unlike renaming the table ->https://github.com/apache/kudu/blob/master/src/kudu/master/catalog_manager.cc#L2825 In case of impala on Kudu on the impala side the replication factor would still be stale (kudu.num_tablet_replicas), although it wouldn't affect the functionality. This might be analogous to renaming the table on the kudu side where we rely on the user's understanding that impala side of the table wouldn't be renamed. Maybe support the alter replication factor from impala which takes care of updating the impala side with the right replication factor as well as changing replication factor from kudu side. -> https://github.com/apache/impala/blob/52f6deec356b9c872575dc5aad12dea963741879/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java#L84 -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 28 Jul 2021 15:53:18 +0000 Gerrit-HasComments: No
