Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@168 PS1, Line 168: hush nit: hash http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@173 PS1, Line 173: HashDimension How do we reconcile with the fact that within common.proto it's called 'HashBucketSchemaPB' and I don't think it's backwards compatible to change the name of that message. Basically, are we ok with inconsistent naming? http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@175 PS1, Line 175: u Previously was signed to keep consistent with the protobuf definition of a `HashBucketSchemaPB` in common.proto and the definition of a HashBucketSchema within the TableCreator class. Do we want to be consistent and keep it unsigned? -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 16 Aug 2021 21:24:23 +0000 Gerrit-HasComments: Yes
