Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc@967 PS2, Line 967: for (const auto& p : data_->range_partitions_) { > nit: remove Done http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/table_creator-internal.cc File src/kudu/client/table_creator-internal.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/table_creator-internal.cc@61 PS2, Line 61: ther > nit: there Done http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition-test.cc@56 PS2, Line 56: const > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@113 PS2, Line 113: sa > nit: have the same Done http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@121 PS2, Line 121: // table's primary key columns, with the restriction that an individual primary : // key column may only be included in a single hash dimension. : // > nit: maybe remove this paragraph, or merge it with the paragraph starting a Done http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@125 PS2, Line 125: // first comes the hash-related part, and then comes the range-related part. : // : > Thank you for adding this. It is a fairly important implementation detail t Ack http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@201 PS2, Line 201: N-d > nit: "A" instead of "The"? Especially since a hash schema may be a per-rang Good point! Done. -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 01:37:51 +0000 Gerrit-HasComments: Yes
