Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@173 PS1, Line 173: > Right: I don't think we can to change the naming in the proto files. Howev Nope, I'm ok with changing the name. That got me thinking though, should we store the map of start range keys to the index of 'range_hash_schemas_' within 'PartitionSchemaPB'? http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@175 PS1, Line 175: tr > Good point -- I reverted the change and updated the other similar places. Sounds good, I think you may also needs to revert back to the static casting in 'HashValueForEncodedColumns' and 'HashValueForRow' -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 01:17:20 +0000 Gerrit-HasComments: Yes
