Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@173 PS1, Line 173: HashDimension > Nope, I'm ok with changing the name. That got me thinking though, should we That's an option, yes. But from the other side, if that data comes from a client, the server side would need to validate that mapping anyway, I guess. http://gerrit.cloudera.org:8080/#/c/17775/1/src/kudu/common/partition.h@175 PS1, Line 175: u > Sounds good, I think you may also needs to revert back to the static castin Why do you think static_cast<uint64_t> is necessary there? I was under impression that the second operand of type int is automatically promoted to uint64_t, no? -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 05:32:18 +0000 Gerrit-HasComments: Yes
