Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17775 )
Change subject: [partition] update naming of related entities ...................................................................... Patch Set 2: Code-Review+1 (7 comments) LGTM, just some minor nits. http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/client.cc@967 PS2, Line 967: // partition schemas are present. nit: remove http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/table_creator-internal.cc File src/kudu/client/table_creator-internal.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/client/table_creator-internal.cc@61 PS2, Line 61: here nit: there http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition-test.cc@56 PS2, Line 56: nit: spacing http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@113 PS2, Line 113: s nit: have the same http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@121 PS2, Line 121: // The range component is called 'range schema', and the collection of per-range : // hash components is called 'hash schema' of a table. So, the partition schema : // for a table consists of the range schema and the hash schema. nit: maybe remove this paragraph, or merge it with the paragraph starting at L111, since partition schema is also defined there. That paragraph also accounts for per-range hash schemas, which isn't mentioned here. http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@125 PS2, Line 125: // In encoded partition keys, first comes the hash-related part, and then comes : // the range-related part. : Thank you for adding this. It is a fairly important implementation detail that is not otherwise well-documented. http://gerrit.cloudera.org:8080/#/c/17775/2/src/kudu/common/partition.h@201 PS2, Line 201: The nit: "A" instead of "The"? Especially since a hash schema may be a per-range hash schema or a table-wide hash schema. -- To view, visit http://gerrit.cloudera.org:8080/17775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a858e97090930b21e9c767dac2f5cc8b9816033 Gerrit-Change-Number: 17775 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 00:50:40 +0000 Gerrit-HasComments: Yes
