Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17779 )
Change subject: KUDU-2671 update range partitioning with custom hash schema ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/client/client.cc@1030 PS3, Line 1030: } Just to clarify, the only way to not enter this block of if/else if statements is if there are no custom hash schemas for any of the ranges defined. In that case, the field 'custom_hash_schemas_ranges' would not be populated correct? http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/partition.cc@195 PS3, Line 195: const auto nit: const auto& http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/master/catalog_manager.cc@1868 PS3, Line 1868: // TODO(aserbin): make sure range boundaries in +1 Ideally, we would decode the range bounds and range hash schemas from the 'custom_hash_schemas_ranges' field at once rather than decoding the range bounds from a separate field. -- To view, visit http://gerrit.cloudera.org:8080/17779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37aae56a33170894f30d6cd73a5698d6cbb7a697 Gerrit-Change-Number: 17779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 28 Aug 2021 02:01:14 +0000 Gerrit-HasComments: Yes
