Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17779 )
Change subject: KUDU-2671 update range partitioning with custom hash schema ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17779/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/1/src/kudu/common/common.proto@358 PS1, Line 358: HashBu > After discussing this offline, the decision was to remove this new data str Ack http://gerrit.cloudera.org:8080/#/c/17779/1/src/kudu/common/common.proto@374 PS1, Line 374: // of the table. Otherwise, particular range > Yep, my initial idea was to eventually deprecate this field. However, sinc Yep I think the alternative approach is a better route at the moment. We can re-evaluate this later although I guess it's better to nail down an approach now so less client side changes will be needed in the future. http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/common.proto@369 PS3, Line 369: //repeated PerRangeHashBucketSchemasPB DEPRECATED_range_hash_schemas = 3; : //repeated RowOperationsPB DEPRECATED_range_bounds = 4; > I guess we could add I lean towards being cautious here and adding reserved fields for 3 and 4 but open to more feedback. -- To view, visit http://gerrit.cloudera.org:8080/17779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37aae56a33170894f30d6cd73a5698d6cbb7a697 Gerrit-Change-Number: 17779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 28 Aug 2021 02:24:22 +0000 Gerrit-HasComments: Yes
