Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17779 )
Change subject: KUDU-2671 update range partitioning with custom hash schema ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/client/client.cc@1020 PS4, Line 1020: range->has_table_wide_hash_schema_ > Yep, there is a difference: an empty hash_schema_ means no hash bucketing f It seems the change I was referring is actually in a follow-up patch. But this 'has_table_wide_hash_schema_' field somehow went into this patch. Removed. Thank you for pointing at this! http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/common/common.proto@353 PS4, Line 353: // This data structure represents a range partition with a custom hash schema. : message RangeWithHashSchemaPB { : // Row operations containing the lower and upper range bound for the range. : optional RowOperationsPB range_bounds = 1; : // Hash schema for the range. : repeated HashBucketSchemaPB hash_schema = 2; : } > Right, they are already decoupled, though I meant that the range bounds we Ah, I see -- thank you for the clarification! I'll think about the ways to make the representation of the ranges to be more optimal, and I agree that without coalesced ranges it's clearer. -- To view, visit http://gerrit.cloudera.org:8080/17779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37aae56a33170894f30d6cd73a5698d6cbb7a697 Gerrit-Change-Number: 17779 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 31 Aug 2021 00:27:10 +0000 Gerrit-HasComments: Yes
