Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17779 )
Change subject: KUDU-2671 update range partitioning with custom hash schema ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/4/src/kudu/common/common.proto@353 PS4, Line 353: // This data structure represents a range partition with a custom hash schema. : message RangeWithHashSchemaPB { : // Row operations containing the lower and upper range bound for the range. : optional RowOperationsPB range_bounds = 1; : // Hash schema for the range. : repeated HashBucketSchemaPB hash_schema = 2; : } > Tablets and ranges are already decoupled de facto -- a single range might h Right, they are already decoupled, though I meant that the range bounds we provide don't necessarily have to correspond to each individual range, but could refer to multiple ranges, eg when there are multiple ranges with the same hash schema, and only one with a custom schema. Especially if the entire keyspace is accounted for, we could save on the number of range keys specified. The last sentence, I meant that right now it's nice that it's clear each range in this partition schema corresponds to a single range, and that it may be more confusing if we were to try coalescing ranges as I described. -- To view, visit http://gerrit.cloudera.org:8080/17779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37aae56a33170894f30d6cd73a5698d6cbb7a697 Gerrit-Change-Number: 17779 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 28 Aug 2021 23:22:35 +0000 Gerrit-HasComments: Yes
