Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17779 )
Change subject: KUDU-2671 update range partitioning with custom hash schema ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/client/client.cc@1030 PS3, Line 1030: } > Just to clarify, the only way to not enter this block of if/else if stateme Yes, correct. I updated the code to be easier for understanding. http://gerrit.cloudera.org:8080/#/c/17779/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/1/src/kudu/common/common.proto@374 PS1, Line 374: // of the table. Otherwise, particular range > Yep I think the alternative approach is a better route at the moment. We ca Right -- it's better to decide now, while we still have some time before the next release. http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/common.proto@369 PS3, Line 369: //repeated PerRangeHashBucketSchemasPB DEPRECATED_range_hash_schemas = 3; : //repeated RowOperationsPB DEPRECATED_range_bounds = 4; > I lean towards being cautious here and adding reserved fields for 3 and 4 b OK, added 'reserved'. http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/common/partition.cc@195 PS3, Line 195: const auto > nit: const auto& I don't think a reference in this case (64-bit) doesn't make much sense compared with the value itself (32-bit), so I think I'll keep the value here. Overall, for primitive types like these there isn't much difference between using reference or the value itself, IIRC. http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17779/3/src/kudu/master/catalog_manager.cc@1868 PS3, Line 1868: // TODO(aserbin): make sure range boundaries in > +1 Right -- I'm thinking to update the corresponding code in both the client and here in catalog manager to rely only on custom_hash_schema_ranges() for the information on ranges when creating a table with custom hash schema for a range. -- To view, visit http://gerrit.cloudera.org:8080/17779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37aae56a33170894f30d6cd73a5698d6cbb7a697 Gerrit-Change-Number: 17779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 28 Aug 2021 05:29:27 +0000 Gerrit-HasComments: Yes
