Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 24: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc@368 PS24, Line 368: read_instance_metadata_files && containers_processed nit: I'm curious, are there actually instances where read_instance_metadata_files is there but not containers_processed? http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h File src/kudu/util/timer.h: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h@68 PS24, Line 68: mutable simple_spinlock lock_; Since we're using atomics, we don't need the spinlock. There are some TOCTOU accesses to consider, but I believe they're benign. -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 24 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 25 Oct 2021 21:25:01 +0000 Gerrit-HasComments: Yes
