Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc@368 PS24, Line 368: read_instance_metadata_files && containers_processed > nit: I'm curious, are there actually instances where read_instance_metadata Yes we have over here -> https://gerrit.cloudera.org/#/c/17730/24/src/kudu/server/server_base.cc@619 This is when there is no previous filesystem present/ when at least one directory doesn't have an instance file present. This caused the test failures in patch set 23. http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h File src/kudu/util/timer.h: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h@38 PS24, Line 38: std::lock_guard<simple_spinlock> l(lock_); > As Andrew pointed, if switching to atomics, locks are not needed. Done http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h@68 PS24, Line 68: mutable simple_spinlock lock_; > Since we're using atomics, we don't need the spinlock. There are some TOCTO Done -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 24 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 26 Oct 2021 03:25:15 +0000 Gerrit-HasComments: Yes
