Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/fs/fs_manager.cc@368 PS24, Line 368: read_instance_metadata_files && containers_processed > Yes we have over here -> https://gerrit.cloudera.org/#/c/17730/24/src/kudu/ Couldn't we still pass the counters in? As long as we reset them first, we should be fine, right? I suppose the concern is that the timers have already been started. Perhaps we need a way to reset them too. As it stands, it's kind of hard to reason about the timings of that code path. -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 25 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 26 Oct 2021 17:56:05 +0000 Gerrit-HasComments: Yes
