Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/17730/22/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/17730/22/src/kudu/fs/block_manager.h@226 PS22, Line 226: std::atomic<int>* containers_processed = nullptr, : std::atomic<int>* containers_total = nullptr) = 0 > As discussed, we need a startup page needs a handle on these value to updat Sounds good to me. http://gerrit.cloudera.org:8080/#/c/17730/22/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17730/22/src/kudu/server/server_base.cc@498 PS22, Line 498: ), > Done and tested too. Works. Great, thanks! (it seems I meant 'you could drop the parenthesis' -- glad you were able to parse this even with that typo) http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h File src/kudu/util/timer.h: http://gerrit.cloudera.org:8080/#/c/17730/24/src/kudu/util/timer.h@38 PS24, Line 38: std::lock_guard<simple_spinlock> l(lock_); As Andrew pointed, if switching to atomics, locks are not needed. -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 24 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 25 Oct 2021 23:32:06 +0000 Gerrit-HasComments: Yes
