[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/17995/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17995/5//COMMIT_MSG@12 PS5, Line 12: discouraging decommissioning masters : this way. > This is also discourages unintentional migration, in which case the diff wo yes, the diff is 2 if there's a change in one of the master addresses http://gerrit.cloudera.org:8080/#/c/17995/5//COMMIT_MSG@15 PS5, Line 15: I39aeee2f52a55a8c29770f748895d3 > nit: this is no longer the case, please update it to reflect the most recen Done http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/master_options-test.cc@223 PS5, Line 223: > style-nit: we typically align end braces with the line that introduced it. Ack http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/master_options-test.cc@226 PS5, Line 226: ); > nit: it isn't clear upon reading this why we're expecting an invalid argume tbh, this line was copied from the previous test, but after double checking this, it should not end in InvalidArgument as far as I could understand, I'll remove this part http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/master_options-test.cc@243 PS5, Line 243: > nit: same here w.r.t. alignment. Also consider spacing like at L219 just to Ack -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Nov 2021 15:09:37 +0000 Gerrit-HasComments: Yes
