[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/dynamic_multi_master-test.cc@1477 PS5, Line 1477: TEST_F(AutoAddMasterTest, TestRestartMastersWhileSomeDown) { > Consider adding another test case to AutoAddMasterTest that, instead of usi I attempted to implement the test as you've described, however ExternalMiniCluster::CreateMaster() is private, so can't call it from the test directly. Calling AddMaster() would achieve the same test that I already added. -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Nov 2021 16:32:16 +0000 Gerrit-HasComments: Yes
