Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17995/6/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/6/src/kudu/master/master_options-test.cc@206 PS6, Line 206: nit for here and below: If ever reading/troubleshooting this test in retrospective, it would help if there were a simple description that explained the essence of this test scenario. http://gerrit.cloudera.org:8080/#/c/17995/6/src/kudu/master/master_options-test.cc@225 PS6, Line 225: : nit: it's preferred to use ASSERT_OK() in this case to output the actual error status and error string if s.ok() is false http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc@296 PS1, Line 296: // We should prevent starting with fewer masters than previously. This way if the user wants to : // remove a master they would have to do it manually > I've run a simple manual test to remove a master via `kudu master remove` a Thank you for the clarification! So far sounds good to me especially if you addressed Andrew's concerns in the follow-up patch sets. I'd also recommend getting feedback from Bankim since he, as the author of the add/remove master CLI tool automation might have a lot of useful context in the scope of adding/removing masters. -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Nov 2021 20:17:32 +0000 Gerrit-HasComments: Yes
