Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/18054/15/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/15/src/kudu/integration-tests/alter_table-test.cc@2535 PS15, Line 2535: // Reset to default disable_rowset_compaction. : ASSERT_OK(table_alterer->AlterExtraConfig( : {{"kudu.table.disable_rowset_compaction", ""}})->Alter()); It seems like this doesn't actually reset anything, and is rather a no-op, at least from the conditional at https://gerrit.cloudera.org/c/18054/15/src/kudu/common/wire_protocol.cc#711 Perhaps we should test that's the case when disable_rowset_compaction=true? Also could you also add a test that ensures we get expected errors when setting the value to an invalid string? -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 04 Jan 2022 22:22:25 +0000 Gerrit-HasComments: Yes
