KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/common/common.proto@476 PS14, Line 476: // If set true, the table will not > nit: This line could be removed. Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc@379 PS14, Line 379: CheckDisableCompac > nit: it should be 'CheckDisableCompact'. Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc@2524 PS14, Line 2524: // Set disable_rowset_compaction tru > nit: Set disable_rowset_compaction true. Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@107 PS14, Line 107: auto total_sum = c->histogra > Could we just traverse `metrics`? Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@113 PS14, Line 113: SERT_EQ( > Is this sleep necessary? Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@137 PS14, Line 137: NO_FATALS(TestNoAffectedMetrics(&op)); : } : : TEST_F(KuduTabletMmOpsTest, TestMinorDeltaCompactionOpCacheStats) { : MinorDeltaCompactionOp op(tablet().get()); > What about adding a new test as 'TestDisableCompact'? It's better to keep t Done http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops.h File src/kudu/tablet/tablet_mm_ops.h: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops.h@43 PS14, Line 43: Return > nit: Return Done -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 31 Dec 2021 06:09:29 +0000 Gerrit-HasComments: Yes
