Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 14: (7 comments) http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/common/common.proto@476 PS14, Line 476: // It's a compact operation switch. nit: This line could be removed. http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc@379 PS14, Line 379: CheckEnableCompact nit: it should be 'CheckDisableCompact'. http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/integration-tests/alter_table-test.cc@2524 PS14, Line 2524: // Set to disable_rowset_compaction. nit: Set disable_rowset_compaction true. http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@107 PS14, Line 107: if (ContainsKey(metrics, c)) Could we just traverse `metrics`? http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@113 PS14, Line 113: SleepFor Is this sleep necessary? http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops-test.cc@137 PS14, Line 137: TableExtraConfigPB extra_config; : extra_config.set_disable_rowset_compaction(true); : NO_FATALS(AlterSchema(*harness_->tablet()->schema(), boost::make_optional(extra_config))); : ASSERT_TRUE(op.DisableCompact()); : NO_FATALS(TestNoAffectedMetrics(&op, { tablet()->metrics()->flush_mrs_duration, What about adding a new test as 'TestDisableCompact'? It's better to keep these tests having single responsibility. http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops.h File src/kudu/tablet/tablet_mm_ops.h: http://gerrit.cloudera.org:8080/#/c/18054/14/src/kudu/tablet/tablet_mm_ops.h@43 PS14, Line 43: Returns nit: Return -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 14 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 30 Dec 2021 11:56:59 +0000 Gerrit-HasComments: Yes
