Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 18: Code-Review+1 (2 comments) Just a couple more nits and this looks good to me. http://gerrit.cloudera.org:8080/#/c/18054/18/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/18/src/kudu/common/common.proto@477 PS18, Line 477: rowset_ Sorry, I suggested this name before knowing that we'd be disabling all compactions. Let's call this 'disable_compaction', since "rowset compaction" in my opinion refers to merge compaction. http://gerrit.cloudera.org:8080/#/c/18054/18/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/18054/18/src/kudu/tablet/tablet_mm_ops.cc@134 PS18, Line 134: << "Rowset compaction is disabled (check --enable_rowset_compaction" : " and disable_rowset_compaction in extra_config)"; nit: align the quotation marks and put the space at the end of the first line, i.e. << "Rowset comp...check --enable_rowset_compaction " "and disable..." same elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 18 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 05 Jan 2022 03:48:06 +0000 Gerrit-HasComments: Yes
