Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8108 PS7, Line 8108: INSTANTIATE_TEST_CASE_P INSTANTIATE_TEST_CASE_P is deprecated, use INSTANTIATE_TEST_SUITE_P instead. See https://github.com/google/googletest/blob/bf66935e07825318ae519675d73d0f3e313b3ec6/googletest/include/gtest/internal/gtest-internal.h#L1303. http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8109 PS7, Line 8109: IsMaster nit: How about 'TestSetFlagForAll'? http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/tool_action_master.cc@188 PS7, Line 188: return Status::OK(); nit: Should we also return RuntimeError here when failed to set flag? -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 13 May 2022 16:32:32 +0000 Gerrit-HasComments: Yes
