Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 8: (3 comments) > Patch Set 7: > > (3 comments) http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8108 PS7, Line 8108: INSTANTIATE_TEST_SUITE_ > INSTANTIATE_TEST_CASE_P is deprecated, use INSTANTIATE_TEST_SUITE_P instead Done http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8109 PS7, Line 8109: sMaster) > nit: How about 'TestSetFlagForAll'? Done http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/tool_action_master.cc@188 PS7, Line 188: } > nit: Should we also return RuntimeError here when failed to set flag? Done -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 16 May 2022 03:24:42 +0000 Gerrit-HasComments: Yes
