Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18515 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18515/5/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18515/5/src/kudu/master/master-test.cc@1024 PS5, Line 1024: KuduPartialRow split2(&kTableSc In addition to just verifying there isn't any error from the server side, for the positive test case it would be great to verify that the range added indeed has the required number of hash partitions and it's possible to write and read to the modified table, getting correct number of rows back. I guess that's much easier to separate as a new test case instead of parameterizing this one. -- To view, visit http://gerrit.cloudera.org:8080/18515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea9e3317d172c9ae76662c44b21fca9a4819930a Gerrit-Change-Number: 18515 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 03 Jun 2022 17:39:17 +0000 Gerrit-HasComments: Yes
