Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18515 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op. ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18515/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18515/6//COMMIT_MSG@9 PS6, Line 9: This commit has the changes needed on the master side to : support this functionality > I didn't see that in PS6. Is it already in this changelist or you are plan I mean does PS6 contains everything needed in that regard or you are going to iterate on that in this or another patch? http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/master-test.cc@313 PS6, Line 313: RETURN_NOT_OK(proxy_->CreateTable(req, resp, &controller)); This fails due to 'resp' being nullptr in MasterTest.TestResetBlockCacheMetricsInSameProcess proxy.cc:257] Check failed: 'resp' Must be non NULL @ 0x7f2f5b6a0fb7 gsignal at ??:0 @ 0x7f2f5b6a2921 abort at ??:0 @ 0x7f2f6200c3c4 google::CheckNotNull<>() at ??:0 @ 0x7f2f6201a048 kudu::rpc::Proxy::SyncRequest() at ??:0 @ 0x7f2f6a47ae5d kudu::master::MasterServiceProxy::CreateTable() at ??:0 @ 0x5e4e40 kudu::master::MasterTest::CreateTable() at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/master/master-test.cc:313 @ 0x5e38aa kudu::master::MasterTest::CreateTable() at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/master/master-test.cc:228 @ 0x64472f kudu::master::MasterTest_TestResetBlockCacheMetricsInSameProcess_Test::TestBody()::$_0::operator()() at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/master/master-test.cc:378 @ 0x7f2f602e84da kudu::AssertEventually() at ??:0 @ 0x5e7070 kudu::master::MasterTest_TestResetBlockCacheMetricsInSameProcess_Test::TestBody() at /home/jenkins-slave/workspace/kudu-master/2/src/kudu/master/master-test.cc:378 @ 0x7f2f71746314 main at ??:0 @ 0x7f2f5b683bf7 __libc_start_main at ??:0 @ 0x50f23a _start at ??:? -- To view, visit http://gerrit.cloudera.org:8080/18515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea9e3317d172c9ae76662c44b21fca9a4819930a Gerrit-Change-Number: 18515 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Jun 2022 23:08:31 +0000 Gerrit-HasComments: Yes
