Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18515 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op. ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/catalog_manager.cc@2625 PS6, Line 2625: custom_hash_schema_size > I guess using has_custom_hash_schema() would be more feature-proof since in Whoops, sorry. I take it back -- custom_hash_schema is repeated field, not optional: there is no has_custom_schema() proto method then. >From the other side, this prompts a question: once we support varying number >of hash dimensions across table's hash schemas, how do we express a case when >a range would have no hash bucketing when there is some table-wide hash schema? It seems we might consider updating the master.proto in a follow-up changelist. Meanwhile, let's keep custom_hash_schema_size() criterion as is. -- To view, visit http://gerrit.cloudera.org:8080/18515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea9e3317d172c9ae76662c44b21fca9a4819930a Gerrit-Change-Number: 18515 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Jun 2022 01:17:59 +0000 Gerrit-HasComments: Yes
