Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18515 )

Change subject: [master] KUDU-2671: Range specific hashing during table alter 
op.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18515/5/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:

http://gerrit.cloudera.org:8080/#/c/18515/5/src/kudu/master/master-test.cc@1024
PS5, Line 1024: ASSERT_FALSE(resp.has_error());
> In addition to just verifying there isn't any error from the server side, f
Yes, that makes sense to validate the count of the hash partitions. In this 
current suite we only have the master spun up and not the table servers so 
reading and writing data wouldn't possible. I was planning to have an 
end-to-end test once we have the client ready as well in 'flex_partitioning_xx' 
tests. What do you think?



--
To view, visit http://gerrit.cloudera.org:8080/18515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9e3317d172c9ae76662c44b21fca9a4819930a
Gerrit-Change-Number: 18515
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Comment-Date: Sat, 04 Jun 2022 01:15:39 +0000
Gerrit-HasComments: Yes

Reply via email to