Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18515 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op. ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18515/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18515/6//COMMIT_MSG@9 PS6, Line 9: This commit has the changes needed on the master side to : support this functionality I didn't see that in PS6. Is it already in this changelist or you are planning to add that later on? http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18515/6/src/kudu/master/master-test.cc@1017 PS6, Line 1017: // Check the number of tablets in the table : EasyCurl c; : faststring buf; : ASSERT_OK(c.FetchURL(Substitute("http://$0/tables";, mini_master_->bound_http_addr().ToString()), : &buf)); : string raw = buf.ToString(); : ASSERT_STR_CONTAINS(raw, "\"tablet_count\":\"2\""); That's OK, but there is a programmatic approach for doing that as well. Please see FlexPartitioningITest::CheckPartitionKeyRangeScan() for details. As for the read/write from the altered table, I guess that could be done in a separate changelist. I guess the best place for such a test is in flex_partitioning_client-test.cc -- To view, visit http://gerrit.cloudera.org:8080/18515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea9e3317d172c9ae76662c44b21fca9a4819930a Gerrit-Change-Number: 18515 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Jun 2022 22:54:38 +0000 Gerrit-HasComments: Yes
