Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18566 )
Change subject: [Doc][Format] Format help document support using Enter Key ...................................................................... Patch Set 10: (3 comments) > Patch Set 9: > > (3 comments) http://gerrit.cloudera.org:8080/#/c/18566/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18566/9//COMMIT_MSG@16 PS9, Line 16: The first line is about 70 length, the second is 8 length, the last > nit: It would be better if you can list the difference in a long help messa Done http://gerrit.cloudera.org:8080/#/c/18566/9/src/kudu/tools/tool_action-test.cc File src/kudu/tools/tool_action-test.cc: http://gerrit.cloudera.org:8080/#/c/18566/9/src/kudu/tools/tool_action-test.cc@157 PS9, Line 157: TEST(ToolActionTest, TestAppendHardWrapped) { > Is this the same with 'AppendHardWrapped' in tool_action.cc? Why not just t Ok. I will declare the function 'AppendHardWrapped' in tool_action-test.h http://gerrit.cloudera.org:8080/#/c/18566/9/src/kudu/tools/tool_action-test.cc@199 PS9, Line 199: string formated_msg6; > Why we should format an empty string to a blank space? The origin algorithm will add a blank space in the tail of every line to make it more beautiful -- To view, visit http://gerrit.cloudera.org:8080/18566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd15bd2de292f534e90ac24e925bf605ddf6d7b Gerrit-Change-Number: 18566 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 09 Jun 2022 06:45:06 +0000 Gerrit-HasComments: Yes
