Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18566 )
Change subject: [Doc][Format] Format help document support using Enter Key ...................................................................... Patch Set 14: (4 comments) > Patch Set 13: > > (4 comments) http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action-test.cc File src/kudu/tools/tool_action-test.cc: http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action-test.cc@175 PS13, Line 175: const string& msg4 = "Attem > In ASSERT_EQ(), the expected value should come first -- that way it's easie Done http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@390 PS13, Line 390: : void AppendHardWrapped(StringPiece to_append, > +1 Done http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@395 PS13, Line 395: DCHEC > nit: this could be constexpr Done http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@427 PS13, Line 427: dst->resize(dst->size() - 1); > There might be some edge cases when either by a mistake or due to unexpecte It needs to remove blank space and Enter Key in the tail. The length of Enter Key is 1. -- To view, visit http://gerrit.cloudera.org:8080/18566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd15bd2de292f534e90ac24e925bf605ddf6d7b Gerrit-Change-Number: 18566 Gerrit-PatchSet: 14 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 20 Jun 2022 03:41:34 +0000 Gerrit-HasComments: Yes
