Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18566 )
Change subject: [Doc][Format] Format help document support using Enter Key ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action-test.cc File src/kudu/tools/tool_action-test.cc: http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action-test.cc@175 PS13, Line 175: ASSERT_EQ(data3.size(), 2); In ASSERT_EQ(), the expected value should come first -- that way it's easier to read the messages if the condition ever triggers. http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@390 PS13, Line 390: // Append 'to_append' to 'dst', but hard-wrapped at 78 columns. : // After any newline, 'continuation_indent' spaces are prepended. > nit: Maybe move these comments to .h file? +1 http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@395 PS13, Line 395: const nit: this could be constexpr http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@427 PS13, Line 427: dst->resize(dst->size() - 1); > I'm not sure if this should be changed to `dst->resize(dst->size() - 2);` t There might be some edge cases when either by a mistake or due to unexpected input, 'to_append' and 'dst' are empty, so dst->size() - 1 becomes a huge number. It's easy to check for such edge cases in the very beginning of the function. -- To view, visit http://gerrit.cloudera.org:8080/18566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd15bd2de292f534e90ac24e925bf605ddf6d7b Gerrit-Change-Number: 18566 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Jun 2022 19:02:42 +0000 Gerrit-HasComments: Yes
