Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18566 )
Change subject: [Doc][Format] Format help document support using Enter Key ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@390 PS13, Line 390: // Append 'to_append' to 'dst', but hard-wrapped at 78 columns. : // After any newline, 'continuation_indent' spaces are prepended. nit: Maybe move these comments to .h file? http://gerrit.cloudera.org:8080/#/c/18566/13/src/kudu/tools/tool_action.cc@427 PS13, Line 427: dst->resize(dst->size() - 1); I'm not sure if this should be changed to `dst->resize(dst->size() - 2);` to remove the extra space and '\n' we added at the end. -- To view, visit http://gerrit.cloudera.org:8080/18566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd15bd2de292f534e90ac24e925bf605ddf6d7b Gerrit-Change-Number: 18566 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 15 Jun 2022 13:00:31 +0000 Gerrit-HasComments: Yes
