Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18566 )
Change subject: [Doc][Format] Format help document support using Enter Key ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18566/15/src/kudu/tools/tool_action-test.cc File src/kudu/tools/tool_action-test.cc: http://gerrit.cloudera.org:8080/#/c/18566/15/src/kudu/tools/tool_action-test.cc@159 PS15, Line 159: AppendHardWrapped(msg1, 0, &formated_msg1); Maybe we should also considering test cases when `continuation_indent` is not 0 or `dst` is not an empty string. http://gerrit.cloudera.org:8080/#/c/18566/15/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/18566/15/src/kudu/tools/tool_action.cc@399 PS15, Line 399: if (newline_pos != string::npos) { : last_line_length = dst->size() - newline_pos; : } What if the 'dst' doesn't contain '\n' but its size >0? Maybe need to update the 'last_line_length' in the case. -- To view, visit http://gerrit.cloudera.org:8080/18566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd15bd2de292f534e90ac24e925bf605ddf6d7b Gerrit-Change-Number: 18566 Gerrit-PatchSet: 15 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 04:20:30 +0000 Gerrit-HasComments: Yes
