Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 16: (5 comments) Thank you very much. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@199 PS9, Line 199: return thread_token_->Schedule([this]() { this->Rebalance(); }, > good! you can add these profits to the commit message. OK http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@227 PS15, Line 227: erTask > nit: threads Done http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@227 PS15, Line 227: oReb > nit: than Done http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@229 PS15, Line 229: static bool negtive_bool = false; > IMO it's not needed to schedule the rebalance tasks so frequently step by s OK, done http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@237 PS15, Line 237: uster' > nit: has been 'using std::nullopt', ' std::' can be omit. Done -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 16 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 09:48:24 +0000 Gerrit-HasComments: Yes
