Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@268 PS8, Line 268: bounds nit: Rename this variable to boundsWithoutHashSchema or something similar to be able to distinguish between both the bounds* variables. http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@700 PS8, Line 700: } Can we add some more functionality here by dropping a partition with custom hash schema and validating the restored data? http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@373 PS8, Line 373: nit: Adjust the indentation. Same in line 385 http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala@162 PS8, Line 162: peak nit: Maybe rename these variables to lowest, low, high, highest -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 8 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 16:16:25 +0000 Gerrit-HasComments: Yes
