Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@268 PS8, Line 268: eturns > nit: Rename this variable to boundsWithoutHashSchema or something similar t Done http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@367 PS8, Line 367: private List<Partition> getRangePartitionsHelper(long timeout, : > Does this really provide any usage guidance for this private method? Removed http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@373 PS8, Line 373: (Kud > nit: Adjust the indentation. Same in line 385 Done http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java File java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18791/5/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java@29 PS5, Line 29: Limite > Right, that's just to inform users of the interface that even if a class is Ack http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java File java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java@31 PS8, Line 31: public > Can we get away by keeping this class package-private? At least, 'gradlew I was running into this error when the class was package-private: java.lang.BootstrapMethodError: java.lang.IllegalAccessError: tried to access class org.apache.kudu.client.RangePartition from class org.apache.kudu.backup.KuduRestore Since RangePartition.java is part of the client package and KuduRestore.scala is part of the backup package, a package private identifier for RangePartition wouldn't work since we need access to it in a different package. http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala@162 PS8, Line 162: high > nit: Maybe rename these variables to lowest, low, high, highest Done -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 04 Aug 2022 01:03:32 +0000 Gerrit-HasComments: Yes
