Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Looks good overall, please also address Abhishek's comment about adding an extra test. Thanks! http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java File java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java@31 PS8, Line 31: public > I was running into this error when the class was package-private: Ah, I see -- that makes sense. Should the audience then be @InterfaceAudience.LimitedPrivate({"kudu-backup", "Test"}) or something like that instead of @InterfaceAudience.LimitedPrivate("Test")? -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 04 Aug 2022 01:25:30 +0000 Gerrit-HasComments: Yes
