Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18791 )
Change subject: KUDU-2671: Restore custom hash schemas properly ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@700 PS8, Line 700: > Can we add some more functionality here by dropping a partition with custom Talked about this offline, encountered a bug that's independent of custom hash schemas so a JIRA will be filed for that. http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@353 PS8, Line 353: @InterfaceAudience.Private : @InterfaceStability.Unstable : public List<Partition> getRangePartitionsWithTableHashSchema(long timeout) throws Exception { : return getRangePartitionsHelper(timeout, true); : } > Do you mind adding a unit test for this new method just to make sure it wor Done http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java File java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/18791/8/java/kudu-client/src/main/java/org/apache/kudu/client/RangePartition.java@31 PS8, Line 31: public > Ah, I see -- that makes sense. Done -- To view, visit http://gerrit.cloudera.org:8080/18791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c28b306f2b630a609231a8fb2a5f5652b028d8e Gerrit-Change-Number: 18791 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 04 Aug 2022 20:59:43 +0000 Gerrit-HasComments: Yes
