Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18846/3/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/3/src/kudu/client/client.h@2693 PS3, Line 2693: explicit KuduScanner(KuduTable* table, std::string request_id = ""); Is there any restriction on the length of request_id, for performance considerations? To ease the use, and make old clusters able to adopt this optimization without upgrading Impala, it's better to generate a unique request_id internally when it's not explicitly provided by the users. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 16 Aug 2022 03:21:20 +0000 Gerrit-HasComments: Yes
